Add closest_points_between_segments() basis path tests for Geometry2D
#48652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some style issues, see the diff from CI: https://github.com/godotengine/godot/pull/48652/checks?check_run_id=2559024734 See Code style guidelines for details, there are instructions for running |
Xrayez
reviewed
May 11, 2021
Calinou
force-pushed
the
geometry-2d-tests
branch
from
7b5e76f to
f421d20
Compare
Calinou
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Tested locally (rebased on top of master 83b916b), it works as expected. Code looks good to me.
I force-pushed a rebased version which also removed a few existing tests, as I think they are made redundant by this PR (please double-check this).
Calinou
changed the title
closest_points_between_segments() basis path tests for Geometry2D
|
Thanks! And congrats for your first merged Godot contribution 🎉 And sorry for the delay getting this reviewed and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests for the closest_points_between_segments method in Geometry2D, based on basis path testing.