Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed_VisualScriptFunctionCall_ReturnHint #48853

Conversation

Gallilus
Copy link
Contributor

@Gallilus Gallilus commented May 19, 2021

Expose the minimal of new virtual methods to give the Node creator all tools needed to create full type hints for input and output ports.

Improves the default guess_output_type() for VisualScriptCustomNode class.

Fixes issues/2692

PS: When developing I have started to (re)create a advanced subcall pluggin as a fix by itself and as a test of the functionality

@Gallilus Gallilus requested a review from a team as a code owner May 19, 2021 17:46
@fire
Copy link
Member

fire commented May 19, 2021

Since there's a lot of pending prs. Do you want me to call you on discord or any other synchronous platform to get a plan to merge them?

@Gallilus Gallilus changed the title Fixed visual script function call return hint Fixed_VisualScriptFunctionCall_ReturnHint May 20, 2021
@Gallilus
Copy link
Contributor Author

See
Expose visual script custom node type hints #48900
for attempt 2

@Gallilus Gallilus closed this May 20, 2021
@Gallilus Gallilus deleted the Fixed_VisualScriptFunctionCall_ReturnHint branch May 22, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants