Use EditorResourcePicker in the Inspector
#48854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
added
enhancement
topic:editor
cherrypick:3.x
akien-mga
approved these changes
May 21, 2021
|
Thanks! |
|
Oh no, I see a typo in my docs 😱 |
YuriSizov
removed
the
cherrypick:3.x
YuriSizov
added a commit
to YuriSizov/godot
that referenced
this pull request
Jun 11, 2021
Backported from godotengine#48854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48797, follow-up to #47260. This also exposes additional properties and methods on
EditorResourcePickeras well as introduces a derivative classEditorScriptPicker(available in the scripting API) that's different from the parent class in that it replaces "New ..." options with special "New Script"/"Extend Script" actions. They open the "Attach Script" dialog, as before.Special behavior for
ViewportTextures was left in the EditorProperty wrapper as it's too specific to the Inspector. I also have concerns about warnings that try to prevent the creation of invalidViewportTextures (when no scene or node is involved and therefore it's impossible to attach it anywhere). These warnings and checks are pretty much superficial and can be easily side-stepped by users by accident or by misunderstanding them. Therefore I think those need to be removed from here and rethought, reimplemented in a more encompassing way. But, alas, I have no idea on what that way may be, so I've tried to keep them as close to the old behavior as possible.