[3.x] Fixed issue where bones become detached if multiple SkeletonIK nodes are used #49031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 24, 2021
…tonIK nodes are used
TwistedTwigleg
force-pushed
the
skeletonik_bone_detachment_fix_godot3
branch
from
a0bfac4
to
ec7b72e
Compare
|
Thanks for the review @akien-mga. One day I'll remember to add those pesky |
akien-mga
approved these changes
May 24, 2021
|
Thanks! |
|
Cherry-picked for 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested locally and in my setups multiple SkeletonIK nodes can now be used without the bones becoming detached. I also tested to make sure BoneAttachment nodes still work, so everything should be good there as well.
Once merged, I'll make a PR for Godot 4.0 with the same changes.
Closes #48772