Backport gltf2 module from master (updated draft) #49051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lyuma The documentation needs to be updated.
|
Keyframe times shift slowly in imported animations, starting with a zero shift at the beginning and increasing and becoming erratic slowly farther into an animation, reaching significant levels at times after about 3 minutes into an animation. This commit fixes the issue by increasing the precision of the floating point numbers used for keyframe time calculations. Only the most significant cases that cause fast accumulation of errors over a short animation duration are fixed. Other cases that would have a marginal benefit from switching to double precision numbers are left for another PR/further analysis. Note that this change has no impact on the runtime performance of games/apps created using Godot. It only affects the GLTF importer. Fixes godotengine#47127. (cherry picked from commit 6770a94)
Co-authored-by: Lcbx <luc.courbariaux@gmail.com>
Includes "Relaxes Node naming constraints in glTF documents to match the Editor."
Move to a more graceful degradation 3d asset import model.
Fix issue when two skeletons end up directly parented. Prevent animating TRS for skinned Mesh node. Fix animating weights on meshes with targets but no weights.
|
Superseded by #49120. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #46783 by @fire
Optimistically includes a backport of the unreviewed PR #48915 as I needed this bugfix to test my content. It's the last commit in the chain and can be ignored if necessary.
Note that GLTF Export crashes when given complicated skinned meshes. This crash is also present in Master. I will need some additional help from fire to resolve export-related bugs.