Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes all 32-bits of all physics, rendering, and navigation layers available in editor. #49088

Closed

Conversation

rune-scape
Copy link
Contributor

@rune-scape rune-scape commented May 26, 2021

Resolves godotengine/godot-proposals#2770
Please let me know if I missed anything.

@qarmin
Copy link
Contributor

qarmin commented May 26, 2021

Can you make a print screen how it looks in editor?

@YuriSizov YuriSizov requested a review from a team May 26, 2021 07:16
@YuriSizov YuriSizov added this to the 4.0 milestone May 26, 2021
@EricEzaM
Copy link
Contributor

EricEzaM commented May 26, 2021

Appears to just be a 4x8 grid.

There was some good discussion about the UX of various grid sizes and implementations in that proposal, not sure why you would jump straight into a PR, rather than discussing there first.

image

@YuriSizov
Copy link
Contributor

Even more discussion on RC too. This doesn't implement one of the described features: latter sections need to be collapsible, we don't want to waste vertical space on showing a bunch of squares most people won't need.

@rune-scape
Copy link
Contributor Author

My bad, I had the code lying around and I failed to read the contributing guidelines. What should happen to this PR?

@EricEzaM
Copy link
Contributor

Once some sort of conclusion is reached in the proposals discussion thread, you can update this PR if that is something you want to do. Otherwise, you can close it if you don't have interest in updating it or would prefer someone else to implement the changes.

@dalexeev
Copy link
Member

dalexeev commented Aug 2, 2021

Please close this as the proposal was implemented in #51039 and #51040.

@akien-mga
Copy link
Member

Superseded by #51039. Thanks for the contribution nonetheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render/Physics layer editor with up to 32 values
6 participants