Fix_VsEditor_drag_in_from_scenetree #49172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the creation of the vs_instances after the decision and allows the creation of set and get propertynodes.
clang-format
remove debug print
|
On hold I have been testing a other way. Info to follow |
This was referenced Jun 19, 2021
|
49749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the creation of the vs_instances after the decision and allows the creation of set and get propertynodes.
fix #26717
fix #49146
Moves the creation of the vs_instances after the decision and allows the creation of set and get propertynodes.
Tested on Master and 3.x
For cherry-pick 3.x I will make a extra PR
3.x requires 1 more argument on for lines.
Also:
Limit suggestions to useful methods, setters and getters. Other VsNodes are not required from this interaction.
Now includes the attached script of a Node for suggestions.