Move code folding into CodeEdit and hide line hiding API #49238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paulb23
force-pushed
the
code_edit_code_folding
branch
from
5c414c6
to
54068b0
Compare
Paulb23
force-pushed
the
code_edit_code_folding
branch
from
54068b0
to
5c618dd
Compare
akien-mga
approved these changes
Jun 16, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #31739
Builds on top of #45393
The main aim of this PR is abstracting out code folding into CodeEdit.
Taking advantage of the string / comment tracking, it will now allow you to fold blocks of strings and comments.
Drawing is still handed by
TextEditdue to how complex it is to draw, at some point I would like to extract this as well, but designing this API will take a while. However, the theming of code folding exists onCodeEdit, whichTextEditwill pull from.In addition to this, for the end of line marker we were using
EditorIcons, this has been removed for a new/sceneiconellipsis.png.Similarly, I have removed
line hidingfrom the API, until we can design a replacement that does not depend explicitly on the line folding use case.closes godotengine/godot-proposals/issues/416
closes the bug part of #19981
clears up some cases of #15690