fix String::get_slice_count #49504
Closed
fix String::get_slice_count #49504
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_slice_count should return 0 if no slice was found. This changes fixes my use case where I tried to parse an URL with a port number ```127.0.0.1:8000/test``` and getting invalid parameter.
|
oh never mind, 1 is correct but the URL checking code is wrong. |
|
Superseded by #49505. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from what I undestand the current behaviour would always return the actual count +1. get_slice_count should return 0 if no slice was found and not 1. This changes fixes my use case where I tried to parse an URL with a port number
127.0.0.1:8000/testand getting invalid parameter.