Remove unused caret_background_color theme item from TextEdit

[Calinou]

This color wasn't used anywhere.

Since this is a theme item (and not a property), removing it shouldn't break existing any projects, so we can probably cherry-pick this for 3.4. This would also be useful to remove the associated editor setting which does nothing.

I found this out while working on #48548.

[Sslaxx]

Any reason not to implement it?

[Calinou]

Any reason not to implement it?

I don't see any practical reason for it. You can already configure the caret color or change it into a block caret.

[Paulb23]

This is a bug, looks like it was missed as part of the RTL refactor.

caret_background_color is the colour of the text behind the caret when block caret is enabled.

[Calinou]

This is a bug, looks like it was missed as part of the RTL refactor.

caret_background_color is the colour of the text behind the caret when block caret is enabled.

I see. Shouldn't we automatically determine this color instead (e.g. by inverting the text color if the caret's opacity is high enough)? Since very few people use the block caret in the first place, I don't think it needs a dedicated setting.

[Paulb23]

Shouldn't we automatically determine this color instead (e.g. by inverting the text color if the caret's opacity is high enough)?

Yeah, I don't see a problem with doing that.

[Calinou]

This should no longer be needed now in latest master, closing.