Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose RenderingServer directional shadow quality setters #49762

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 20, 2021

This allows configuring directional shadow quality and size at run-time.

I've also included a bunch of documentation improvements along the way.

This closes #18621.

Note: Not cherry-pickable to the 3.x branch as it only sets the shadow quality once at startup. It would require significant refactoring to have a similar feature in 3.x.

Example code

RenderingServer.directional_shadow_quality_set(RenderingServer.SHADOW_QUALITY_SOFT_ULTRA)
RenderingServer.directional_shadow_atlas_set_size(8192, false)

This allows configuring directional shadow quality and size at run-time.
@Calinou Calinou requested review from a team as code owners June 20, 2021 15:44
@Calinou Calinou added this to the 4.0 milestone Jun 20, 2021
@Calinou Calinou deleted the renderingserver-expose-directional-shadow-setters branch August 3, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directional Shadow Atlas Size Cannot be Modified at Runtime
2 participants