-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak StandardMaterial3D's default height properties #49947
Tweak StandardMaterial3D's default height properties #49947
Conversation
Calinou
commented
Jun 27, 2021
•
edited
Loading
edited
- Set the default height scale to 5.0 and multiply it by 0.01 in the shader.
- Document heightmap properties in BaseMaterial3D class reference.
86137b6
to
c352376
Compare
c352376
to
706dede
Compare
I dont think this is a great idea, if you are making a mobile game, deep parallax is very expensive and makes the technique unusable. |
706dede
to
391d64d
Compare
I amended the pull request to leave Deep Parallax disabled by default. Hopefully, #50383 should make non-deep parallax more usable on most materials. |
391d64d
to
53b4ac0
Compare
Regarding this, what is generally the value range expected in similar applications/materials? I would think its the same spaces as the world. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this in PR review meeting and agreed that it should be scaled by 0.01 (so if you interpret the unit as meter this property would be edited as cm, though this shouldn't be mentioned as is in the docs probably).
The scaling should be explained in the docs.
Does this mean the default height should be 5 now? |
Yes. |
d40ddfd
to
b339bbd
Compare
Rebased and tested again, with the default height changed to 5.0. I also filled in the documentation for all heightmap properties in BaseMaterial3D. I think the note on heightmap normalization will be helpful in particular, as it's something I've found to improve the effect in many cases 🙂 We could add an import option to normalize an image, so that you don't need to use an image editor for this. |
You need to convert the |
- Set the default height scale to 5.0 and multiply it by 0.01 in the shader. - Document heightmap properties in BaseMaterial3D class reference.
b339bbd
to
c6cca43
Compare
Thanks! |