Fix GraphNode port position when the control has the Expand flag #49970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeldhamDev
added
bug
topic:gui
cherrypick:3.x
akien-mga
approved these changes
Jun 29, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #39810
When a GraphNode child has the (vertical) Expand size flag enabled, the port icon position and the get_connection_*_position are different, resulting in the following artifacts:
(The bigger Godot logo has the Expand flag)
I fix this by using the full control size, and not just the minimum one.
I don't test Visual Script and Visual Shader, but if the control size is the same of
Control.get_combined_minimum_size(which seems to be the default behaviour), there shouldn't be any regression.Test scene:
graphedit.zip