Refactor and move easing equations #50165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you need help with cicd? |
|
No, I think I managed to fix it. |
akien-mga
reviewed
Sep 24, 2021
akien-mga
reviewed
Sep 24, 2021
KoBeWi
force-pushed
the
take_it_easing
branch
3 times, most recently
from
5f48fa7
to
2a3a9f3
Compare
akien-mga
approved these changes
Sep 24, 2021
KoBeWi
force-pushed
the
take_it_easing
branch
from
2a3a9f3
to
e38bf2f
Compare
|
Still has conflicts on the removed file. |
KoBeWi
force-pushed
the
take_it_easing
branch
2 times, most recently
from
0d84945
to
24c1037
Compare
KoBeWi
force-pushed
the
take_it_easing
branch
from
24c1037
to
11e7963
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supposed to close #22513
I mostly cleaned up the code. I wasn't sure what to do with the easings file, it's so heavily modified now that it's not much of a third-party. Although we should probably credit Penner somewhere, his equations are MIT/BSD.
EDIT:
Ah, I forgot. Here is a test scene:
TweenTest.zip