Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Unicode multiplication symbol for the viewport size display #50222

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Use the Unicode multiplication symbol for the viewport size display #50222

merged 1 commit into from
Jul 7, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 6, 2021 •
edited
Loading

I didn't add this to #45596 because I forgot about String::utf8() back then.

Preview

image

@Calinou Calinou requested a review from a team as a code owner July 6, 2021 19:53
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:3d topic:editor labels Jul 6, 2021
@Calinou Calinou added this to the 4.0 milestone Jul 6, 2021
@Calinou Calinou removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 6, 2021
@Calinou Calinou mentioned this pull request Jul 6, 2021
Merged
@akien-mga
Copy link
Member

What's the risk of custom user fonts not supporting it?

@Calinou
Copy link
Member Author

Calinou commented Jul 6, 2021 •
edited
Loading

What's the risk of custom user fonts not supporting it?

Most fonts out there have this symbol, so the risk is very low. Also, we're already using the multiplication sign in the VoxelGI editor plugin.

If we really want to avoid missing characters (3.x) or visible "tofu" characters (master) regardless of the font used, we could consider loading the default editor font as a fallback font when a custom editor font is used.

@akien-mga akien-mga merged commit 82d4a89 into godotengine:master Jul 7, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the editor-information-use-multiply-sign branch August 3, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Calinou @akien-mga