Fix various typos #50250
Fix various typos #50250
Conversation
|
If you are fixing comment typos, you could also fix their style (I mean the ones modified). Our preferred style is |
| @@ -115,7 +115,7 @@ class GodotProcessor extends AudioWorkletProcessor { | |||
| this.input = new RingBuffer(p_data[1], avail_in); | |||
| this.output = new RingBuffer(p_data[2], avail_out); | |||
| } else if (p_cmd === 'stop') { | |||
| this.runing = false; | |||
| this.running = false; | |||
There was a problem hiding this comment.
I don't see any other changed occurrence nor any other match, so this might be unused. Poke @Faless.
There was a problem hiding this comment.
@akien-mga see line 129
process(inputs, outputs, parameters) {
if (!this.running) {
return false; // Stop processing.
There was a problem hiding this comment.
Thanks, that's actually a bugfix then (or will create a bug, we'll see :D).
There was a problem hiding this comment.
Please advise how to proceed?
There was a problem hiding this comment.
I've checked all mentions of worklets in issues and pull requests in this repository, and don't think there will be any conflicts. The misspelling leads me to believe that a feature was missing, and this feature seems reasonable, so I see no reason not to push unless I have missed something.
That can be done but it's tedious work while the typos here were fixed by a script. I wouldn't bother until we can convince all core contributors to actually follow that comment style (otherwise we keep having new comments to fix). |
I mean, there is like 20 modified comments here that use the wrong style. Fixing the style too isn't that much more work. |
My point is that those comments were fixed in 5 s by a script. Changing their style however requires opening the 63 changed files, locating the modified lines and changing the style manually -> 10 min of work. It's OK if OP is willing to do it but it's not a requirement for me in this PR. |
|
Added requested revisions in e185824 |
|
Please squash the commits into one, see PR workflow for instructions. |
|
Force pushed a rebase to squash the 28 commits and solve merge conflicts. |
|
@akien-mga please advise |
|
I'll fix it up again, you repushed all old commits on top of my earlier rebase so it can't be merged as is. |
Found via `codespell -q 3 -S ./thirdparty,*.po,./DONORS.md -L ackward,ang,ans,ba,beng,cas,childs,childrens,dof,doubleclick,fave,findn,hist,inout,leapyear,lod,nd,numer,ois,ony,paket,seeked,sinc,switchs,te,uint`
|
💩 |
|
Thanks! |
Found via
codespell -q 3 -S ./thirdparty,*.po,./DONORS.md -L ackward,ang,ans,ba,beng,cas,childs,childrens,dof,doubleclick,fave,findn,hist,inout,leapyear,lod,nd,numer,ois,ony,paket,seeked,sinc,switchs,te,uint