Allow unindent without selection #50289
Conversation
ghost
self-requested a review
as a 
scene/gui/code_edit.cpp
Outdated
| cursor_set_column(MAX(0, cc - spaces_to_remove)); | ||
| return; |
There was a problem hiding this comment.
The two returns can be removed as they're both the last statements of mutually exclusive branches.
There was a problem hiding this comment.
This was changed on purpose.
Might be worth allowing configuration of this behaviour? I notice that QT creator has a couple different behaviours for unindenting.
As for this specific PR, if the old behaviour is preferred by most, you can remove that entire method and call unindent_line directly.
|
Or alternatively, I could have it remove preceding spaces/tabs if there are any and otherwise unindent? That way it would cancel any tabs placed in the middle of a line while also providing the expected unindent functionality. |
|
That's an idea worth exploring. Though I worry that it might feel inconsistent. |
What was the rationale for changing it? I also tend to think that the behavior proposed by this PR makes sense, at least that's what I'm used to in other editors. The OP deleted their account so this needs to be redone by someone else in a new PR. |
|
As of simplescreenrecorder-2022-02-08_21.31.58.mp4 |
|
@Calinou Try Shift+Tabbing with caret inside words. |
This allows a user to press shift+tab to unindent a line without needing to make a selection. Previously, this would remove spaces or tabs preceding the cursor, and an active selection was necessary to actually unindent the line. Now, it always unindents the line the cursor is on by removing spaces or tabs at the front.
Resolves: #50279