Use interleaved gradient noise for distance fade #50297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
This was referenced Jul 16, 2021
Calinou
force-pushed
the
distance-fade-use-interleaved-gradient-noise
branch
from
5ae34d5 to
2e6791c
Compare
|
This looks great, but give me a bit more time before merging as I may need to do more changes in shadow mapping when I get some clues on the remaining bugs. |
reduz
approved these changes
Jul 30, 2022
|
Would be good to rebase to be safe. |
This provides better visuals and performance compared to the previous ordered dither.
Calinou
force-pushed
the
distance-fade-use-interleaved-gradient-noise
branch
from
2e6791c to
e919e51
Compare
|
Rebased and tested again, it works as expected. |
|
Thanks! |
Calinou
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterversion of #64052. Follow-up to #50294.This provides better visuals and performance compared to the previous ordered dither. On my GTX 1080 in a 4K editor, I get 230 FPS in locations where I would get 210 FPS previously.
The new shader performs better since it has much less instructions and branching to do.
I also tested this PR on the
3.xbranch together with #50294 and it works fine there, both in GLES3 and GLES2.Preview
Note: These images should be viewed on a desktop device at 1:1 resolution by clicking them. Otherwise, they will not look as expected due to the nature of dithering.
Pixel Alpha (for comparison)
Pixel Dither (new)