-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Improve and streamline VisualScriptFuncNodes Call Set Get #50709
[3.x] Improve and streamline VisualScriptFuncNodes Call Set Get #50709
Conversation
We need to make sure that scripts created in Godot 3.3 can still be opened in Godot 3.4, otherwise users would lose work (it's a binary format so if it's incompatible, it will just been seen as corrupt and they won't be able to open it). |
I don't think the binary wil complain, think the logic wil use pass_object opose to the value. |
I'm not familiar with the |
This PR improves and streamlines the workflow for VisualScriptFunctionNodes Call Set Get Uniform design. Drag in set-get from tree is now working. port 'pass' not backported to 3.x to keep script backwards compatibility
Exactly that is the compatibility error. |
0ab6495
to
af1ea18
Compare
Thanks! |
Revert a part of godotengine#50709. Adding a sequence port to basic type set breaks backwards compatibility
Revert a part of godotengine#50709. Adding a sequence port to basic type set breaks backwards compatibility
Revert a part of godotengine#50709. Adding a sequence port to basic type set breaks backwards compatibility
This PR improves and streamlines the workflow for VisualScriptFunctionNodes Call Set Get
Uniform design.
Drag in set-get from tree is now working.
3.x version of #49749
Controlsgc.zip
Compatibility whit older scripts is NOT guaranteed as I added the pass output port for get instance.
I do want to note that the other changes is are a real big improvement to the UX