Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the purpose of the default asset library URLs in the editor #50768

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 23, 2021

localhost was removed as it won't work out of the box. It can be added by the user if they're working on the asset library itself.

This won't affect existing installations due to how the editor settings are stored, but existing installations will keep working fine.

Note: There's also the question of whether we should still list localhost by default, since the editor asset library URLs can now be configured freely by the user. Most people won't be hosting their development server on port 80 since it requires root privileges.

Preview

image

Old reversion of this PR

image

@Calinou Calinou added this to the 4.0 milestone Jul 23, 2021
@Calinou Calinou added cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jul 23, 2021
@akien-mga
Copy link
Member

We can probably remove localhost by now, yes.

`localhost` was removed as it won't work out of the box. It can be added
by the user if they're working on the asset library itself.

This won't affect existing installations due to how the editor settings
are stored, but existing installations will keep working fine.
@Calinou Calinou force-pushed the editor-asset-library-urls-clarify branch from 4dfc7b0 to eac8ba6 Compare July 23, 2021 11:02
@Calinou
Copy link
Member Author

Calinou commented Jul 23, 2021

We can probably remove localhost by now, yes.

Done:

image

@akien-mga akien-mga merged commit 8cddd3b into godotengine:master Jul 23, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 23, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

@Calinou Calinou deleted the editor-asset-library-urls-clarify branch August 3, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants