Fix bindings generator range iterator errors #50861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
reviewed
Jul 25, 2021
| @@ -1686,7 +1686,7 @@ Error BindingsGenerator::_generate_cs_method(const BindingsGenerator::TypeInterf | |||
| // Add the current arguments to the signature | |||
| // If the argument has a default value which is not a constant, we will make it Nullable | |||
| { | |||
| if (F != p_imethod.arguments.front()) { | |||
| if (&F != &(p_imethod.arguments.front()->get())) { | |||
There was a problem hiding this comment.
For the .front() ones, the other option is to do what we did in #50828.
raulsntos
force-pushed
the
fix-bindings-generator
branch
from
e3d8b35 to
b3274a7
Compare
neikeq
approved these changes
Jul 25, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors in the
binding_generators.cppcaused by PRs #50511 and #50809.Please, keep in mind I'm not super knowledgeable about C++ so maybe there is a better way to fix this.