Fix Set range iterator implementation, Use C++ iterators in the Mono module #50917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #50511, #50809 and #50899.
This PR converts all the for loops in the Mono module to use C++ Range Iterators for
List,MapandSet. Usingconstwhenever possible.I had to fix the
Setimplementation to be able to convert those, otherwise it wouldn't compile.There are for loops using
SelfListandOrderedHashMapbut since those structures don't implement Range Iterators I couldn't translate those.I'm not well-versed in C++ so I may have made mistakes.