Fix Bugs w/ Octahedral Compression Implementation #51258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #51256 but only when split stream is on |
Initial octahedral compression incorrectly wrote tangent to the buffer using an offset of 3 rather than 4, losing the sign of the tangent vector needed for things like tangent space for texturing mapping GLES3 renderer used remove_custom_define rather than set_conditional to change back to the default conditional state the scene shader should be in
The-O-King
force-pushed
the
normal_compression_fix
branch
from
6b059d9 to
6c643af
Compare
The-O-King
changed the title
clayjohn
approved these changes
Aug 5, 2021
akien-mga
approved these changes
Aug 5, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial octahedral compression incorrectly wrote tangent to the buffer
using an offset of 3 rather than 4, losing the sign of the tangent
vector needed for things like tangent space for texturing mapping
GLES3 renderer used remove_custom_define rather than set_conditional to
change back to the default conditional state the scene shader should be
in