[macOS export] Implements ad-hoc signing on Linux/Windows. #51310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
reviewed
Aug 6, 2021
bruvzg
force-pushed
the
branch
12 times, most recently
from
afd43a7 to
4dd3d06
Compare
This was referenced Aug 12, 2021
akien-mga
reviewed
Jan 17, 2022
akien-mga
reviewed
Jan 17, 2022
akien-mga
reviewed
Jan 18, 2022
akien-mga
reviewed
Jan 18, 2022
akien-mga
reviewed
Jan 18, 2022
…a privacy settings, entitlements warnings and error checking.
akien-mga
approved these changes
Jan 18, 2022
|
Thanks a ton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
codesignto ad-hoc sign macOS exports on Linux/Windows (and macOS without Xcode installed), to allow valid macOS export from any platform. Using real signatures is not supported (MbedTLS used by Godot for cryptography do not have PKCS#7/CMS support), but without notarization there are no benefits over ad-hoc anyway.Tested on macOS, Linux and Windows with classic, mono + GDNative libraries.
Note for testing: there are changes to export template
Info.plist, some features (usage message) won't work if it's used with old template, but signing should work in any case.Fixes: #51007, #48076, #48803