Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes crash when AnimationPlayer reset on save #51541

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Fixes crash when AnimationPlayer reset on save #51541

merged 1 commit into from
Aug 12, 2021

Conversation

timothyqiu
Copy link
Member

AnimationPlayer::apply_reset() may return an invalid reference on error. This situation was not handled, so later access to the invalid Ref crashed the editor.

To reproduce the crash:

  1. Animate any node property with RESET track created.
  2. Clear the AnimationPlayer's Root Node property.
  3. Save the scene, and the editor crashes when the progress bar reaches the end.

@timothyqiu timothyqiu added bug topic:editor crash cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Aug 12, 2021
@timothyqiu timothyqiu added this to the 4.0 milestone Aug 12, 2021
@akien-mga akien-mga merged commit f88593c into godotengine:master Aug 12, 2021
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the reset-crash branch August 12, 2021 06:12
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyqiu @akien-mga