-
-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move 3D scene import classes to their own folder #51569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an opinion, merge if desired.
The only problem is this breaks prs and on-going development churn, but that is expected from pr developers.
c59740b
to
54b4a00
Compare
54b4a00
to
079313c
Compare
f2fd918
to
b48b91d
Compare
b48b91d
to
c5ab805
Compare
c5ab805
to
258ca7a
Compare
258ca7a
to
75378c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR meeting: We should agree on a proposal on how to reorg the editor code
75378c2
to
6d68e3a
Compare
1308de4
to
f64eb0a
Compare
f64eb0a
to
1f7caef
Compare
1f7caef
to
0aa54d1
Compare
ac74908
to
aa7fefe
Compare
86a0dc1
to
214185b
Compare
214185b
to
801769a
Compare
801769a
to
89dee54
Compare
89dee54
to
a8f7a04
Compare
a8f7a04
to
b181bf5
Compare
44cd664
to
a61d639
Compare
a61d639
to
b3ec49f
Compare
b3ec49f
to
c41f3c9
Compare
c41f3c9
to
b899e86
Compare
b899e86
to
7c1d060
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know @fire approved this back in 2021. I also think this is reasonable, so I'm going to put my approval on here too to make clear that there is nothing in terms of asset pipeline that is blocking this.
7c1d060
to
3cd3dfe
Compare
Thanks! |
This PR moves 3D scene import classes to their own folder (
editor/import/3d
). Previously the 3D scene import classes were in the same place as mostly unrelated files such as texture and audio importers.