Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to mobile renderer #51768

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Fixes to mobile renderer #51768

merged 1 commit into from
Aug 17, 2021

Conversation

reduz
Copy link
Member

@reduz reduz commented Aug 17, 2021

  • Make sure shaders are named, to aid in debug in case of failure
  • SceneRenderRD was being wrongly initialized (virtual functions being called when derivative class not initialized).
  • Fixed some bugs resulting on the above being corrected.

@reduz reduz requested a review from a team as a code owner August 17, 2021 00:37
@Calinou Calinou added this to the 4.0 milestone Aug 17, 2021
BastiaanOlij
BastiaanOlij approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small nitpicking things, love the shader name addition, thanks for cleaning up a few of my mistakes :)

@reduz reduz force-pushed the fixes-to-mobile-renderer-2 branch from 51f26ad to 7544d55 Compare August 17, 2021 12:28
@reduz reduz requested a review from a team as a code owner August 17, 2021 12:28
@reduz reduz force-pushed the fixes-to-mobile-renderer-2 branch from 7544d55 to 48b3683 Compare August 17, 2021 15:31
@reduz
Fixes to mobile renderer
6027cd0 
* Make sure shaders are named, to aid in debug in case of failure
* SceneRenderRD was being wrongly initialized (virtual functions being called when derivative class not initialized).
* Fixed some bugs resulting on the above being corrected.
@reduz reduz force-pushed the fixes-to-mobile-renderer-2 branch from 48b3683 to 6027cd0 Compare August 17, 2021 16:52
@akien-mga akien-mga merged commit 819aa47 into godotengine:master Aug 17, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees
No one assigned
Labels
bug enhancement topic:rendering
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@reduz @akien-mga @BastiaanOlij @Calinou