-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Upgrade Emscripten to 2.0.27. #51832
Conversation
Update Godot Javascript FS library to manually depend on ERRNO_CODES.
For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good I would really like that in 3.4
yeah let's cherry pick the library fix, especially since we tend to recommend using a recent version of emscripten (except for the mono build). |
Cherry-picked for 3.4. |
Cherry-picked for 3.3.3. |
Btw is this reflected for template generation for gdnative and threads versions? The ones uploaded with the release for example of 3.4 - beta4 |
@object71 as mentioned above, we'll likely keep using |
Actually 3.4 is using It's 3.3.x which stays on |
@Faless I am particularly interested in working with newer version of emscripten on my project which is a GDNative project. There is an issue open on godot-cpp - godotengine/godot-cpp#554 that emscripten above 2.0.17 gives an error. So I was having trouble generating my own godot export templates (for some reason the build crashes for gdnative emscripten) and I wanted to take the ones in the 3.4 beta if they are with the higher version to see if that will resolve the gdnative issue with version > 2.0.17 . |
@object71 I see, well, that's basically the problem. Every new version of emscripten breaks something (like this issue shows), so updating close to stable releases means risking to break the stable release. There's nothing we can do about this, since we don't control emscripten development. Regarding the gdnative issue, the best suggestion I can give is build your plugin with the same version of emscripten that's used by the godot release you are targeting. |
Update Godot Javascript FS library to manually depend on ERRNO_CODES (required after emscripten-core/emscripten#14730).
Closes #51829