Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgrade Emscripten to 2.0.27. #51832

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Aug 18, 2021

Update Godot Javascript FS library to manually depend on ERRNO_CODES (required after emscripten-core/emscripten#14730).

Closes #51829

Update Godot Javascript FS library to manually depend on ERRNO_CODES.
@Faless Faless requested review from a team as code owners August 18, 2021 10:02
@akien-mga akien-mga modified the milestones: 3.4, 4.0 Aug 18, 2021
@akien-mga akien-mga added cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Aug 18, 2021
@akien-mga
Copy link
Member

For 3.x and 3.3 I'll likely keep the current versions (2.0.25 and 2.0.15 respectively), but I guess the JS library change is still worth cherry-picking for users making custom builds?

Copy link
Contributor

@object71 object71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I would really like that in 3.4

@akien-mga akien-mga merged commit 919040f into godotengine:master Aug 18, 2021
@Faless
Copy link
Collaborator Author

Faless commented Aug 18, 2021

but I guess the JS library change is still worth cherry-picking for users making custom builds?

yeah let's cherry pick the library fix, especially since we tend to recommend using a recent version of emscripten (except for the mono build).

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 18, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

@object71
Copy link
Contributor

object71 commented Aug 19, 2021

Btw is this reflected for template generation for gdnative and threads versions? The ones uploaded with the release for example of 3.4 - beta4

@Faless Faless deleted the js/4.x_ci-2.0.27 branch August 19, 2021 14:30
@Faless
Copy link
Collaborator Author

Faless commented Aug 19, 2021

@object71 as mentioned above, we'll likely keep using 2.0.15 for 3.4.
Any particular reason you want them built with 2.0.27?

@akien-mga
Copy link
Member

as mentioned above, we'll likely keep using 2.0.15 for 3.4.

Actually 3.4 is using 2.0.25 currently. It could use 2.0.27 (or later) if need be, we just need to settle on a version for 3.4 beta 5 at the latest IMO.

It's 3.3.x which stays on 2.0.15 as it was the stable release when 3.3-stable was published, and we know upgrading can be tricky.

@object71
Copy link
Contributor

object71 commented Aug 19, 2021

@Faless I am particularly interested in working with newer version of emscripten on my project which is a GDNative project. There is an issue open on godot-cpp - godotengine/godot-cpp#554 that emscripten above 2.0.17 gives an error.

So I was having trouble generating my own godot export templates (for some reason the build crashes for gdnative emscripten) and I wanted to take the ones in the 3.4 beta if they are with the higher version to see if that will resolve the gdnative issue with version > 2.0.17 .

@Faless
Copy link
Collaborator Author

Faless commented Aug 19, 2021

@object71 I see, well, that's basically the problem. Every new version of emscripten breaks something (like this issue shows), so updating close to stable releases means risking to break the stable release. There's nothing we can do about this, since we don't control emscripten development.
Which is why we have been more wary of updating recently.

Regarding the gdnative issue, the best suggestion I can give is build your plugin with the same version of emscripten that's used by the godot release you are targeting.
For now, you can check which version is used by which release here (choosing the right branch, that's for 3.3).
We could probably have the emscripten version written in the README to make things easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants