-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide TextFiles #51845
Hide TextFiles #51845
Conversation
Thanks! |
So I recently ran into this. It was actually very confusing as I read docs and thought I could just load the TextFile as a Resource and of course I couldn't load it as a resource. So thanks for hiding them! I did some digging and I think you guys are very close to being able to just load it as a resource in script. If I understand correctly, part of the challenge for that to happen is that resources have a special syntax like the following:
which makes a lot of sense because all resources are reloaded through a unified interface( As a user I still think this might be useful for something like a Story(which is the case in my team) that we would like to keep as text file and have it behave like any other resource that we can load. Not sure if this is the right place for this comment, but figured might leave it here since the PR is related. Hope these points make sense(perhaps I missed something?). |
I should add that I'll be willing to write this code. I know y'all busy so I would not mind working on this, but I figured I'd bring up it first in case there is something I'm missing. |
Thanks for the quick reply! |
With #47301 the
TextFile
resources can at last be hidden.Given both #47301 and #47268 have been cherry picked for
3.x
, I'm tempted have this backported as well, as I hope nobody is relying onTextFiles
. But, this would be a breaking change that would need communicating on the release.Included another minor bug fix that I missed in #51698.
closes #36297
closes #39964
closes #37999