Add preliminary support for subprojects #51895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xrayez
changed the title
ResourceLoader
Xrayez
force-pushed
the
subproject-paths
branch
from
67a7482
to
6620396
Compare
Save and load subproject paths. Allows to save resources in a subproject with paths localized. Remaps paths when checking subproject resources. This caused GDScript to not load `gdc/gde` files, and likely any other file which is remapped on export. Fix `ResourceLoader` not returning subproject for existing paths. This caused issues with packed scenes. Expose `Resource.project_path`.
Xrayez
force-pushed
the
subproject-paths
branch
from
6620396
to
0670806
Compare
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3
to
c58391c
Compare
|
Closing as this contributor can no longer update this further. |
|
Can someone else pick this up instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves part of godotengine/godot-proposals#1205. Originally presented in godotengine/godot-proposals#1205 (comment) in 3.2, but rebased to 3.4 now due to conflicts.
This PR is not meant to be merged of course, but I'd like to track this solution because I've been using it successfully in my project, and other people expressed some interest as well. This PR will be eventually closed once a proper solution for godotengine/godot-proposals#1205 is out by @reduz (maybe in Godot 4.1?). Feedback welcome, of course!