Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspelled "overriden" #52107

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Fix misspelled "overriden" #52107

merged 1 commit into from
Aug 26, 2021

Conversation

timothyqiu
Copy link
Member

Overriden → Overridden

This is a typo in the recent GDVIRTUAL PR (#51970).

This typo also appear in the doc for SkeletonModification3DJiggle, so it's fixed too.

In recent GDVIRTUAL PR and SkeletonModification3DJiggle doc.
@timothyqiu timothyqiu requested review from a team as code owners August 25, 2021 18:07
@YeldhamDev YeldhamDev added this to the 4.0 milestone Aug 25, 2021
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a simple Google search to confirm usage and it matches the rename tooverridden.

Need to wait for cicd.

@fire
Copy link
Member

fire commented Aug 25, 2021

Since this touches core, would like to check if renaming causes problems with @reduz.

@reduz reduz merged commit d19b12d into godotengine:master Aug 26, 2021
@timothyqiu timothyqiu deleted the overriden branch August 26, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants