Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Show error when missing expression after ternary else #52706

Merged
merged 1 commit into from
Sep 15, 2021
Merged

GDScript: Show error when missing expression after ternary else #52706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/gdscript/gdscript_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2275,6 +2275,10 @@ GDScriptParser::ExpressionNode *GDScriptParser::parse_ternary_operator(Expressio

operation->false_expr = parse_precedence(PREC_TERNARY, false);

if (operation->false_expr == nullptr) {
push_error(R"(Expected expression after "else".)");
}

return operation;
}

Expand Down
4 changes: 4 additions & 0 deletions modules/gdscript/tests/scripts/parser/errors/missing_expression_after_ternary_else.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
func test():
var x = 1 if false else
print("oops")
print(x)
2 changes: 2 additions & 0 deletions modules/gdscript/tests/scripts/parser/errors/missing_expression_after_ternary_else.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
GDTEST_PARSER_ERROR
Expected expression after "else".