Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix crash in Tween.follow_property #52925

Merged
merged 1 commit into from
Sep 22, 2021
Merged

[3.x] Fix crash in Tween.follow_property #52925

merged 1 commit into from
Sep 22, 2021

Conversation

timothyqiu
Copy link
Member

Check p_object for null before using it.

Fixes #52831. This PR targets 3.x because Tween API changed on master and follow_property does not exist there.

@timothyqiu
Fix crash in Tween.follow_property
45b4304 
Check `p_object` for null before using it.
@timothyqiu timothyqiu added this to the 3.4 milestone Sep 22, 2021
@timothyqiu timothyqiu requested a review from a team as a code owner September 22, 2021 05:42
@akien-mga akien-mga merged commit 23bb588 into godotengine:3.x Sep 22, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Sep 22, 2021
Closed
@timothyqiu timothyqiu deleted the follow-property-null branch September 22, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:animation
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyqiu @akien-mga