Fix Platform Thread Override #53044
Merged
Fix Platform Thread Override #53044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an old issue with sons, having a define poiting to a header messes with scons dependency resolution, scons doesn't see the header in the macro as a dependency. We dealt with this prevously on the refcount file: https://github.com/godotengine/godot/blob/2.0/core/safe_refcount.h#L94 Because those couldn't be implemented in a virtual class. Ideally this would also be a virtual class, but since it's not, this was the best solution. edit: maybe we can add a comment to clarify that platform_thread.h is in platform/ ? |
lucypero
force-pushed
the
thread_override
branch
2 times, most recently
from
828a1fa to
78bcd67
Compare
akien-mga
reviewed
Sep 29, 2021
akien-mga
reviewed
Sep 29, 2021
akien-mga
added
cherrypick:3.x
lucypero
force-pushed
the
thread_override
branch
from
78bcd67 to
5fe1857
Compare
akien-mga
approved these changes
Sep 29, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52734
This way, Scons knows about whatever header you include in
platform_thread.h(which can be created inplatform/[platform])In the linked PR, Scons has no way of detecting changes in
PLATFORM_CUSTOM_THREAD_H