Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto LOD generation for blendshapes #53608

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Fix auto LOD generation for blendshapes #53608

merged 1 commit into from
Oct 9, 2021

Conversation

JFonS
Copy link
Contributor

@JFonS JFonS commented Oct 9, 2021

Blendshapes were not taken into account when splitting vertex normals in LODs, now they are.

Also fixes the same issue as #53401 but with less verbose errors (not sure if that's better or worse).

@JFonS JFonS added this to the 4.0 milestone Oct 9, 2021
@JFonS JFonS requested a review from fire October 9, 2021 18:40
@JFonS JFonS requested a review from a team as a code owner October 9, 2021 18:40
@akien-mga akien-mga merged commit 53426bd into godotengine:master Oct 9, 2021
@akien-mga
Copy link
Member

Thanks!

@fire fire mentioned this pull request Oct 9, 2021
Closed
@lyuma lyuma mentioned this pull request Oct 12, 2021
Closed
@JFonS JFonS deleted the fix_blendshape_lods branch October 27, 2021 08:43
@MJacred MJacred mentioned this pull request Jul 19, 2022
Open
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@fire fire Awaiting requested review from fire

Assignees
No one assigned
Labels
bug topic:import topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JFonS @akien-mga @clayjohn