Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default_texture_param in shader pipeline to support uniform arrays #53914

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Oct 17, 2021

Continuation of #49485. This will allow users to use set_default_texture_param/get_default_texture_param (in Shader or RenderingServer) for assigning default textures to uniform array by using an optional index parameter.

@Chaosus Chaosus requested review from a team as code owners October 17, 2021 11:42
@Chaosus Chaosus added this to the 4.0 milestone Oct 17, 2021
@Chaosus Chaosus force-pushed the shader_default_texture_param branch 3 times, most recently from d4d995e to 710459e Compare October 17, 2021 11:56
@Chaosus Chaosus requested a review from clayjohn October 17, 2021 12:25
@akien-mga
Copy link
Member

Needs a rebase.

@Chaosus Chaosus force-pushed the shader_default_texture_param branch from 710459e to 9fa310a Compare November 12, 2021 09:44
@Chaosus Chaosus force-pushed the shader_default_texture_param branch from 9fa310a to 826e781 Compare November 12, 2021 09:53
@akien-mga akien-mga merged commit a54bd6e into godotengine:master Nov 12, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants