Warn if custom ambient light color is ignored due to sky contribution #53927
Conversation
Calinou
force-pushed
the
environment-sky-contribution-warn-if-ignored
branch
6 times, most recently
from
f9ea7ea to
0f3b7fc
Compare
|
I am not convinced this is a good idea. You may have set a placeholder color then added a sky, and ultimately you are forced to move the color back to zero to get rid of this warning. I have been thinking for a while that it may be better to have a system where we can show warnings at property/resourrce level rather than just at node level. |
Indeed, this is something I feel is missing right now 🙂 That said, we can resolve the original issue by implementing godotengine/godot-proposals#4524 too. |
We can't use `_validate_property()` in Environment on a non-boolean value (it breaks the slider). Instead, emit a node configuration warning in WorldEnvironment. The downside is that the warning is only displayed when the scene is (re)loaded in the editor, since we can't listen for Environment resource changes.
Calinou
force-pushed
the
environment-sky-contribution-warn-if-ignored
branch
from
0f3b7fc to
4d7e566
Compare
This is implemented by #68420, btw. |
We can't use
_validate_property()in Environment on a non-boolean value (it breaks the slider). Instead, emit a node configuration warning in WorldEnvironment. The downside is that the warning is only displayed when the scene is (re)loaded in the editor, since we can't listen for Environment resource changes.This closes #47786. See also #39965 (comment).