Only update render target directly if ARVR mode is off #54258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m4gr3d I vaguely remember you had an issue when you switched transparency on with Godot going nutsy with the viewport as well. This should fix that too (though i don't really get why it triggered the behaviour, unless I'm mixing up issues). |
akien-mga
reviewed
Oct 26, 2021
BastiaanOlij
force-pushed
the
fix_arvr_resize_issue
branch
from
78e80c8
to
3bd6088
Compare
akien-mga
approved these changes
Oct 26, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using XR plugins like the Oculus Desktop and OpenXR in combination with switching the ARVR mode on for the primary viewport, window resizing will attempt to resize the viewport while the XR server is now in control of this viewport.
This PR makes sure that we do not resize the viewport unless the ARVR mode is turned off, or at the opportune moment when it is on. Should also fix some related issues such as switching transparency.
Fixes #41889