Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ColorPicker presets [3.x] #54439

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

Geometror
Copy link
Member

@Geometror Geometror commented Oct 30, 2021

This PR is basically a backport of #51700 except the compatibility breaking renames.
I also did some minor adjustments to better fit the 3.x editor theme.

grafik

Bugsquard edit: Closes #43270

@Geometror Geometror requested a review from a team as a code owner October 30, 2021 22:33
@Calinou Calinou added this to the 3.5 milestone Oct 30, 2021
@Geometror Geometror force-pushed the color-picker-presets-3.x branch from 9e4d001 to d162ea4 Compare October 31, 2021 00:39
@akien-mga akien-mga force-pushed the 3.x branch 2 times, most recently from 71cb8d3 to c58391c Compare January 6, 2022 22:40
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

Given the age of the last update, might be worth doing a rebase and quick re-test that it works as intended before merging.

@Geometror Geometror force-pushed the color-picker-presets-3.x branch from d162ea4 to 3654865 Compare January 17, 2022 14:29
@Geometror
Copy link
Member Author

@akien-mga Rebased and tested. Seems to work fine:

grafik

@akien-mga akien-mga merged commit 90353b3 into godotengine:3.x Jan 17, 2022
@akien-mga
Copy link
Member

Thanks!

qaptoR pushed a commit to qaptoR/godot that referenced this pull request Aug 6, 2022
quick stitch to complete svg-recolorizer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants