Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add a flag to EditorResourcePicker to differentiate selection contexts #54507

Merged

Conversation

YuriSizov
Copy link
Contributor

@YuriSizov YuriSizov commented Nov 2, 2021

Fixes #54465 for 3.x. The EditorResourcePicker's resource_selected signal now passes a boolean flag that marks if the action was triggered by the context menu. Inspector dock uses that flag to forcefully open a new inspector.

master version: #54509

@YuriSizov YuriSizov added this to the 3.4 milestone Nov 2, 2021
@YuriSizov YuriSizov requested a review from a team as a code owner November 2, 2021 11:17
@YuriSizov YuriSizov requested review from akien-mga and a team November 2, 2021 11:17
@YuriSizov YuriSizov changed the title Add a flag to EditorResourcePicker to differentiate selection contexts [3.x] Add a flag to EditorResourcePicker to differentiate selection contexts Nov 2, 2021
@akien-mga akien-mga added the bug label Nov 2, 2021
@akien-mga akien-mga merged commit 1a1a450 into godotengine:3.x Nov 2, 2021
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov deleted the editor-resource-picker-edit-3.x branch November 2, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants