[macOS] Fix crash handler not printing function names on M1 Macs. #55019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 16, 2021
| args.push_back("x86_64"); | ||
| #elif defined(__aarch64__) | ||
| args.push_back("arm64"); |
There was a problem hiding this comment.
That shouldn't happen, but in theory of new arches were added then the call would become invalid as there's no #else condition. Maybe it should raise an error in #else?
Or is it mandatory to set the arch, or can we get away with just letting it infer things?
There was a problem hiding this comment.
Moved args.push_back("-arch"); into the ifdef, it's an optional flag. This way it should try to infer architecture if we do not know it.
bruvzg
force-pushed
the
macos_crash_handler
branch
from
f27d4ef to
c8037ef
Compare
akien-mga
approved these changes
Nov 16, 2021
|
Thanks! |
bruvzg
added
the
cherrypick:3.x
|
This fix is relevant for 3.x as well. |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect architecture name used to call
atos.