Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention how to add margins to Button's icon #55054

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 17, 2021

Closes #23828

@KoBeWi KoBeWi added enhancement documentation cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:gui labels Nov 17, 2021
@KoBeWi KoBeWi added this to the 4.0 milestone Nov 17, 2021
@KoBeWi KoBeWi requested a review from a team as a code owner November 17, 2021 11:54
@@ -78,6 +78,7 @@
</member>
<member name="icon" type="Texture2D" setter="set_button_icon" getter="get_button_icon">
Button's icon, if text is present the icon will be placed before the text.
To edit margin and spacing of the icon, use [code]hseparation[/code] theme property of [Button] and [code]content_margin_*[/code] properties of the used [StyleBox]es.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we still lack support for [theme_item hseparation] even after #29868 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suspicion that operators and constructors don't have their own tags either 👀 (And they are also missing from doc status).

@akien-mga akien-mga merged commit f9b4547 into godotengine:master Nov 17, 2021
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the marginalized_icon branch November 17, 2021 13:14
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 17, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to define margins for the icon in Button
4 participants