windows get_latin_keyboard_variant() implementation and gdscript binding, #5503

[SuperUserNameMan]

This is the OS_Windows::get_latin_keyboard_variant() implementation of OS::get_latin_keyboard_variant(), and its GDscript binding.

This method was already implemented for OSX.

It is still missing for LINUX, ANDROID and others platforms for which it will return QWERTY by default.

There is an open discussion about the purpose of this function, and the alternative workarounds here #5503. (edit : also, for reference, you'll also find there some resources and info to help you debug in case of problems)

edit : also, for reference, here are some python tool scripts and CSV datasheets that will be useful for adding missing keyboards and for debugging :
https://github.com/SuperUserNameMan/os_windows_get_latin_keyboard_variant

[reduz]

amazing

On Sat, Jul 2, 2016 at 4:15 PM, SuperUserNameMan notifications@github.com
wrote:

This is the OS_Windows::get_latin_keyboard_variant() implementation of
OS::get_latin_keyboard_variant(), and its GDscript binding.

This method was already implemented for OSX.

It is still missing for LINUX, ANDROID and others platforms for which it

will return QWERTY by default.

You can view, comment on, or merge this pull request online at:

#5525
Commit Summary

• windows get_latin_keyboard_variant() implementation and gdscript
  binding

File Changes

• M core/bind/core_bind.cpp
  https://github.com/godotengine/godot/pull/5525/files#diff-0 (12)
• M core/bind/core_bind.h
  https://github.com/godotengine/godot/pull/5525/files#diff-1 (2)
• M platform/windows/os_windows.cpp
  https://github.com/godotengine/godot/pull/5525/files#diff-2 (62)
• M platform/windows/os_windows.h
  https://github.com/godotengine/godot/pull/5525/files#diff-3 (1)

Patch Links:

• https://github.com/godotengine/godot/pull/5525.patch
• https://github.com/godotengine/godot/pull/5525.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#5525, or mute the thread
https://github.com/notifications/unsubscribe/AF-Z23gOdJ7TjBpZVo5uNA4G6VdR__xIks5qRri1gaJpZM4JDvEW
.

[SuperUserNameMan]

PLEASE DONT MERGE
sorry, false alarm

[akien-mga]

Could you merge the second commit into the first one? This should be doable wit git rebase -i HEAD~2, replace the pick for the second commit with fixup, and save. Then you should have a single commit with the log of the first one and the contents of the two, which you can force push to update this PR git push --force.

[SuperUserNameMan]

@akien-mga : Yes it worked.