Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Rationalize Node removals and deletions #55514

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

RandomShaper
Copy link
Member

Version of #55512 for 3.x.

It's the same, less the tree_exited comes in the same order as tree_exiting part, to avoid compat breakage. Otherwise it should be fine.

- Regarding preservation of owner, `free()` and `remove_child()` now behave the same: owner is kept during `tree_exiting` signal and `null` during `tree_exited`.
- Superfluous code to handle cancelation of ownership is removed.
@akien-mga akien-mga merged commit e22f7ea into godotengine:3.x Jan 5, 2022
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the better_node_delete_3.x branch January 5, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants