[GDScript] Add 'sort' and 'has' methods to pooled arrays #55650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdiduk
force-pushed
the
pooled-arrays
branch
5 times, most recently
from
bfd5d70 to
b1ba738
Compare
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3 to
c58391c
Compare
akien-mga
approved these changes
Jul 2, 2022
This is a backport from 4.0 to 3.x that adds 'sort' and 'has' methods to the following types: - PoolByteArray - PoolIntArray - PoolRealArray - PoolStringArray - PoolVector2Array - PoolVector3Array - PoolColorArray For all the types above, the methods 'sort' and 'has' have been exposed to the GDNative API (v. 1.3) Since the method 'has' was already implemented in GDScript before, in this commit it has been only exposed to GDNative API. The classes documentation is updated. The method 'sort' uses the exisging class "Sorter". Pooled arrays in 4.0 are rewritten, that's why this backport is not completely indentical to the original PR made for 4.0 (see godotengine#32144).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport from 4.0 to 3.x that adds 'sort' and 'has' methods to the following types in GDScript and GDNative:
PoolByteArrayPoolIntArrayPoolRealArrayPoolStringArrayPoolVector2ArrayPoolVector3ArrayPoolColorArrayThe method
haswas already implemented in GDScript before (see #60856), so in this PR it has been only exposed to GDNative API.The method
sortis implemented using the existing classSorter.The both
hasandsortmethods of the Pooled Array classes are exposed to the GDNative CORE API 1.3The classes documentation is updated.
Pooled arrays in 4.0 are rewritten, that's why this backport is not completely identical to the original PR made for 4.0 (see #32144).
Bugsquad edit: This closes #5202.