Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] OSX: Add signing of directory structure when exporting for OSX #56250

Merged
merged 1 commit into from
Jan 7, 2022
Merged

[3.x] OSX: Add signing of directory structure when exporting for OSX #56250

merged 1 commit into from
Jan 7, 2022

Conversation

piiertho
Copy link
Contributor

Port of #56047

@piiertho piiertho requested review from a team as code owners December 26, 2021 14:29
@YuriSizov
Copy link
Contributor

Please amend the commit to use the original commit message, at least as the first line.

@Calinou Calinou added this to the 3.5 milestone Dec 26, 2021
@YuriSizov YuriSizov changed the title Port #56047 to 3.x branch [3.x] OSX: Add signing of directory structure when exporting for OSX Dec 26, 2021
@piiertho
Copy link
Contributor Author

Please amend the commit to use the original commit message, at least as the first line.

This is done :)

@piiertho
Copy link
Contributor Author

piiertho commented Jan 6, 2022

Why some checks have been cancel ?

@Calinou
Copy link
Member

Calinou commented Jan 6, 2022

Why some checks have been cancel ?

I don't know. I re-ran them manually; let's see if they complete this time.

@piiertho
Copy link
Contributor Author

piiertho commented Jan 6, 2022

Why some checks have been cancel ?

I don't know. I re-ran them manually; let's see if they complete this time.

Still fails with cancel :s

@akien-mga
Copy link
Member

There's a GitHub Actions bug on this PR, when builds are queued for too long (which happens with macOS jobs as they're more limited so we run out of allocated resources fast) it cancels them.

I think it's because this was a first time contributor PR with manual approval, there must be a buggy codepath there.

I've tried to restart them 4 times but there's always an hour or more of waiting time for a macOS build so they get cancelled.

Maybe try to rebase and force push. Now that you have a merged PR it should no longer require approval and might side step that bug.

Though there seems to be another CI bug on the 3.x branch right now so maybe wait a bit.

@akien-mga akien-mga force-pushed the 3.x branch 2 times, most recently from 71cb8d3 to c58391c Compare January 6, 2022 22:40
… OSX.

Add exporting of folder structure in PlugIns when exporting for OSX.
@akien-mga akien-mga merged commit 3c0cf6b into godotengine:3.x Jan 7, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants