[3.x] Clear pending function states when reloading GDScript #56296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3
to
c58391c
Compare
akien-mga
approved these changes
Jan 12, 2022
|
Thanks! |
|
Cherry-picked for 3.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56116
Since reloading a GDScript frees previous
GDScriptFunctions, pendingGDScriptFunctionStates should also be cleared.The MRP won't crash after this PR. The animations won't be working after reload because they're done via an infinite loop with
yield()sleeps. I don't think we can remap the function states to resume inside newly created functions, as they could be completely different.