Convert octahedral compressed normals/tangents on 3.x meshes #56330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Dec 30, 2021
nikitalita
force-pushed
the
convert-old-octahedral
branch
from
a90baf0 to
01629ea
Compare
|
fixed. |
nikitalita
force-pushed
the
convert-old-octahedral
branch
from
01629ea to
41e577a
Compare
|
Cc @The-O-King |
The-O-King
approved these changes
Dec 30, 2021
akien-mga
reviewed
Jan 7, 2022
nikitalita
force-pushed
the
convert-old-octahedral
branch
from
41e577a to
209b5b4
Compare
|
Fixed |
|
There's a third-party submodule that should be removed. |
nikitalita
force-pushed
the
convert-old-octahedral
branch
from
209b5b4 to
92a0cbc
Compare
|
fixed |
akien-mga
approved these changes
Jan 8, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Octahedral compression was added to the 3.x branch (#46800), the functionality to convert 3.x meshes upon import was not updated. As a result, it is broken on meshes that have Octahedral compression enabled (this is enabled by default in 3.4).
This PR adds converting octahedral compressed normals and tangents in old 3.x format meshes back into their uncompressed form upon import.