Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding UTF-8 filenames on unzipping. #56517

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 5, 2022

In case of extracting templates, it's not relevant, since there are no non ASCII filename, but might cause issues similar to Android export (reading ZIP to align) on extracting asset store and project zips.

Fixes #18222

@bruvzg bruvzg added this to the 4.0 milestone Jan 5, 2022
@bruvzg bruvzg requested review from a team as code owners January 5, 2022 12:34
@akien-mga akien-mga added cherrypick:3.4 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jan 5, 2022
@akien-mga akien-mga merged commit 75c0628 into godotengine:master Jan 5, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 5, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrupt exported Android APK when project files include non-ASCII (accented) characters like ñ
2 participants