Skip Draco-compressed glTF 3d format files. #56613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jan 8, 2022
akien-mga
approved these changes
Jan 8, 2022
akien-mga
added
cherrypick:3.4
cherrypick:3.x
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.4.3. |
|
Is there any progress in supporting Draco Extension in Godot 4.0? |
|
I am not expecting to support draco because we are using the mesh optimizer. We could expose more features from like gltfpack, but draco and meshoptimizer do the same thing and they conflict. There is a runtime file size cost. I recommend using gltf transform to convert the files into core gltf profiles or the features godot supports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stage 0 of adding Draco is don't crash with Draco files.
https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_draco_mesh_compression
Stage 1 is to implement the entire gltf extensions standard.
Stage 2 is to sketch a proposal for adding draco and then putting the proposal into the pile.
Fixes: #47822